Commit 79fcfabc authored by Ivaria's avatar Ivaria
Browse files

Workaround for Blizzard bug in secure button onenter/onleave. Should improve...

Workaround for Blizzard bug in secure button onenter/onleave. Should improve sticking keybindings when off VuhDo frames. See: https://wow.curseforge.com/projects/vuhdo/issues/442
parent 52fab72e
## Interface: 70100
## Title: VuhDo ['vu:du:]
## Author: Iza@Gilneas, humfras, Ivaria@Hyjal
## Version: 3.79
## Version: 3.80
## Notes: Raid Frames providing click-heal functionality, buff and debuff control, main tank management and much more
## SavedVariablesPerCharacter: VUHDO_CONFIG, VUHDO_PANEL_SETUP, VUHDO_SPELL_ASSIGNMENTS, VUHDO_HOSTILE_SPELL_ASSIGNMENTS, VUHDO_MM_SETTINGS, VUHDO_PLAYER_TARGETS, VUHDO_MAINTANK_NAMES, VUHDO_BUFF_SETTINGS, VUHDO_POWER_TYPE_COLORS, VUHDO_SPELLS_KEYBOARD, VUHDO_SPELL_CONFIG, VUHDO_BUFF_ORDER, VUHDO_SPEC_LAYOUTS, VUHDO_GROUP_SIZE, VUHDO_RAID, VUHDO_INDICATOR_CONFIG
## SavedVariables: VUHDO_DEFAULT_LAYOUT, VUHDO_DEFAULT_PROFILE, VUHDO_PROFILES, VUHDO_MANUAL_ROLES, VUHDO_SPELL_LAYOUTS, VUHDO_USER_CLASS_COLORS, VUHDO_DEBUFF_BLACKLIST, VUHDO_BOUQUETS, VUHDO_COMBAT_LOG_TRACE, VUHDO_GLOBAL_CONFIG, VUHDO_DEBUG
......
......@@ -329,6 +329,10 @@ function VUHDO_setupAllHealButtonAttributes(aButton, aUnit, anIsDisable, aForceT
aButton:SetAttribute("_onleave", "self:ClearBindings();");
aButton:SetAttribute("_onshow", "self:ClearBindings();");
aButton:SetAttribute("_onhide", "self:ClearBindings();");
aButton:SetAttribute(
"_onmousedown",
"if not self:IsUnderMouse(false) then self:ClearBindings(); end"
);
end
end
local VUHDO_setupAllHealButtonAttributes = VUHDO_setupAllHealButtonAttributes;
......
## Interface: 70100
## Title: VuhDo ['vu:du:] - Options
## Author: Iza@Gilneas, humfras, Ivaria@Hyjal
## Version: 3.79
## Version: 3.80
## Notes: VuhDo Options
## SavedVariables: VUHDO_OPTIONS_SETTINGS
## SavedVariablesPerCharacter: VUHDO_GLOBAL_ICONS, VUHDO_GI_SCAN_IDX
......
......@@ -66,7 +66,7 @@
</Layers>
</Frame>
<Button name="VuhDoDebuffIconTemplate" virtual="true" inherits="SecureUnitButtonTemplate,SecureHandlerEnterLeaveTemplate,SecureHandlerShowHideTemplate">
<Button name="VuhDoDebuffIconTemplate" virtual="true" inherits="SecureUnitButtonTemplate,SecureHandlerEnterLeaveTemplate,SecureHandlerShowHideTemplate,SecureHandlerMouseUpDownTemplate">
<Frames>
<Frame name="$parentB" enableMouse="false">
<Layers>
......@@ -116,7 +116,7 @@
</Backdrop>
</Frame>
<Button name="VuhDoButtonSecureTargetTemplate" virtual="true" inherits="SecureUnitButtonTemplate,SecureHandlerEnterLeaveTemplate,SecureHandlerShowHideTemplate">
<Button name="VuhDoButtonSecureTargetTemplate" virtual="true" inherits="SecureUnitButtonTemplate,SecureHandlerEnterLeaveTemplate,SecureHandlerShowHideTemplate,SecureHandlerMouseUpDownTemplate">
<Size>
<AbsDimension x="95" y="18" />
</Size>
......@@ -225,7 +225,7 @@
</Button>
<Button name="VuhDoButtonSecureTemplate" virtual="true" inherits="SecureUnitButtonTemplate,SecureHandlerEnterLeaveTemplate,SecureHandlerShowHideTemplate">
<Button name="VuhDoButtonSecureTemplate" virtual="true" inherits="SecureUnitButtonTemplate,SecureHandlerEnterLeaveTemplate,SecureHandlerShowHideTemplate,SecureHandlerMouseUpDownTemplate">
<Size>
<AbsDimension x="95" y="18" />
</Size>
......
......@@ -360,6 +360,10 @@ function VUHDO_getOrCreateBuffSwatch(aName, aParent)
tButton:SetAttribute("_onleave", "self:ClearBindings();");
tButton:SetAttribute("_onshow", "self:ClearBindings();");
tButton:SetAttribute("_onhide", "self:ClearBindings();");
tButton:SetAttribute(
"_onmousedown",
"if not self:IsUnderMouse(false) then self:ClearBindings(); end"
);
else
tButton = _G[aName .. "GlassButton"];
end
......
Version 3.80
Known issues:
-- Limited support for Class Order Hall Bodyguards
-- Bodyguards can be used in panels when set to target or focus
-- Bodyguards have no unit ID so for now are only partially supported
-- Incoming heal estimation reported is not even close to accurate
-- Bug in Blizzard API UnitGetIncomingHeals() - returns bogus values
-- Patch 7.1 disabled retrieval of unit facing and position in instances
-- This was an intentional breaking change by Blizzard
-- This breaks AOE Advice, Clusters and out-of-range direction arrow
-- At this time there is no way to fix or renable these features
Bugfixes:
-- Workaround for Blizzard bug in secure button onenter/onleave
-- Should improve sticking keybindings when off VuhDo frames
-- See: https://wow.curseforge.com/projects/vuhdo/issues/442
Improvements:
--------------------------------------------------------------
Version 3.79
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment