Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Open sidebar
Valery Kornilovich
VuhDo
Commits
2468540a
Commit
2468540a
authored
10 years ago
by
Ivaria
Browse files
Options
Download
Email Patches
Plain Diff
Fixed bug in combat log parsing of incoming swing damage amount - closes CurseForge ticket 326
parent
998d6ab1
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
5 deletions
+7
-5
VuhDoEventHandler.lua
VuhDoEventHandler.lua
+6
-1
changelog.txt
changelog.txt
+1
-4
No files found.
VuhDoEventHandler.lua
View file @
2468540a
...
...
@@ -350,8 +350,13 @@ function VUHDO_OnEvent(_, anEvent, anArg1, anArg2, anArg3, anArg4, anArg5, anArg
--VUHDO_Msg(anEvent);
if
"COMBAT_LOG_EVENT_UNFILTERED"
==
anEvent
then
if
VUHDO_VARIABLES_LOADED
then
VUHDO_parseCombatLogEvent
(
anArg2
,
anArg8
,
anArg11
,
anArg13
,
anArg15
);
-- SWING_DAMAGE - the amount of damage is the 12th arg
-- ENVIRONMENTAL_DAMAGE - the amount of damage is the 13th arg
-- for all other events with the _DAMAGE suffix the amount of damage is the 15th arg
VUHDO_parseCombatLogEvent
(
anArg2
,
anArg8
,
anArg12
,
anArg13
,
anArg15
);
if
VUHDO_INTERNAL_TOGGLES
[
36
]
then
-- VUHDO_UPDATE_SHIELD
-- for SPELL events with _AURA suffixes the amount healed is the 16th arg
-- for SPELL_HEAL/SPELL_PERIODIC_HEAL the amount absorbed is the 17th arg
VUHDO_parseCombatLogShieldAbsorb
(
anArg2
,
anArg4
,
anArg8
,
anArg13
,
anArg16
,
anArg12
,
anArg17
);
end
end
...
...
This diff is collapsed.
Click to expand it.
changelog.txt
View file @
2468540a
...
...
@@ -8,6 +8,7 @@ Bugfixes:
-- Fixed bug where isInSameZone check always returned true
-- BuffWatch now correctly ignores other players outside the players zone
-- Global scanner perf bump when 'same zone' limit selected
-- Fixed bug in the combat log parsing for incoming swing damage amount
-- Removed deprecated spells and abilities
-- Removed Death Knight spell Unholy Frenzy
-- Removed Druid spell Nourish
...
...
@@ -63,10 +64,6 @@ Features:
TODO:
-- Updated combat log event processing for multistrike
-- SWING_DAMAGE/SPELL_DAMAGE/SPELL_PERIODIC_DAMAGE has new params after crushing (isOffHand, multistrike)
-- SPELL_HEAL/SPELL_PERIODIC_HEAL has new param after critical (multistrike)
-- SPELL_MISSED/SPELL_PERIODIC_MISSED/RANGE_MISSED/SWING_MISSED has new param after isOffHand (multistrike)
-- Updated incoming/over heal estimation
-- Appears to not be a bug in VuhDo
-- UnitGetIncomingHeals API seems to return bogus values on beta/PTR?
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment