Bring classic from v3.102 up to v3.107

.gitignore

+.release/*
+!.release/release.sh
+!.release/.env

.gitlab-ci.yml

+stages:
+  - build
+  - deploy
+
+.releases: &releases
+  only:
+    - /^v\d[\d\.]*(-classic-?)?(-(alpha|beta)-\d+)?$/
+    
+before_script:
+  - apk add --no-cache bash curl git subversion zip luacheck
+
+luacheck:
+  stage: build
+  script:
+    - luacheck . -q && echo "Lua check passed!" || echo "Lua check failed!"
+
+package:
+  stage: build
+  only:
+    - tags
+    - web
+  script:
+    - cd .release
+    - chmod +x ./release.sh
+    - ./release.sh -d
+  artifacts:
+    paths:
+      - .release/VuhDo/
+      - .release/VuhDoOptions/
+      - .release/*.zip
+  
+curseforge:
+  <<: *releases
+  stage: deploy
+  environment:
+    name: CurseForge
+    url: https://www.curseforge.com/wow/addons/vuhdo
+  script:
+    - cd .release
+    - chmod +x ./release.sh
+    - ./release.sh -ocelzWHG
+
+wowinterface:
+  <<: *releases
+  stage: deploy
+  environment:
+    name: WoWInterface
+    url: https://www.wowinterface.com/downloads/info14239-VuhDo.html
+  script:
+    - cd .release
+    - chmod +x ./release.sh
+    - ./release.sh -ocelzLHG
+
+gitlab:
+  <<: *releases
+  stage: deploy
+  environment:
+    name: GitLab
+    url: https://gitlab.vuhdo.io/vuhdo/vuhdo/releases
+  script:
+    - cd .release
+    - chmod +x ./release.sh
+    - ./release.sh -ocelzLWH
\ No newline at end of file

.gitlab/issue_templates/Bug.md

+**Confirm the issue lies within VuhDo:**
+
+Please first disable all add-ons other than VuhDo and VuhDo Options and see if your issue persists.
+
+**Describe your environment:**
+
+* *VuhDo version (e.g. v3.102, Classic or Retail)*
+	* You can retrieve this by running the following command in-game: `/dump GetAddOnMetadata("VuhDo", "Version")`
+* *World of Warcraft region (ie. Americas/Oceanic, EU, CN or KR)*
+* *World of Warcraft client language (eg. enUS)*
+	* You can retrieve this by running the following command in-game: `/dump GetLocale()`
+
+**Summary of the issue:**
+
+Describe your issue here.
+
+**Expected behaviour:**
+
+Tell me what you feel should be happening.
+
+**Actual behaviour:**
+
+Tell me what is happening instead, contrary to the expectations you documented above.
+
+Tell me how to reproduce your issue. Please provide step-by-step instructions.
+
+**Related error messages:**
+
+Please first install the following two add-ons to assist in capturing any error messages in-game:
+
+* [BugGrabber](https://www.curseforge.com/wow/addons/bug-grabber)
+* [BugSack](https://www.curseforge.com/wow/addons/bugsack)
+
+Next, disable all add-ons except for Bugsack, Bug Grabber, VuhDo and VuhDo Options.
+Capture any VuhDo related error messages and paste them here verbatim.

.luacheckrc

+std = "lua51"
+max_line_length = false
+exclude_files = {
+	"**/Libs",
+	".luacheckrc"
+}
+only = {
+	"011", -- syntax
+	"1", -- globals
+}
+ignore = {
+	"11/SLASH_.*", -- slash handlers
+	"1/[A-Z][A-Z][A-Z0-9_]+", -- three letter+ constants
+}
+globals = {
+	-- wow std api
+	"abs",
+	"acos",
+	"asin",
+	"atan",
+	"atan2",
+	"bit",
+	"ceil",
+	"cos",
+	"date",
+	"debuglocals",
+	"debugprofilestart",
+	"debugprofilestop",
+	"debugstack",
+	"deg",
+	"difftime",
+	"exp",
+	"fastrandom",
+	"floor",
+	"forceinsecure",
+	"foreach",
+	"foreachi",
+	"format",
+	"frexp",
+	"geterrorhandler",
+	"getn",
+	"gmatch",
+	"gsub",
+	"hooksecurefunc",
+	"issecure",
+	"issecurevariable",
+	"ldexp",
+	"log",
+	"log10",
+	"max",
+	"min",
+	"mod",
+	"rad",
+	"random",
+	"scrub",
+	"securecall",
+	"seterrorhandler",
+	"sin",
+	"sort",
+	"sqrt",
+	"strbyte",
+	"strchar",
+	"strcmputf8i",
+	"strconcat",
+	"strfind",
+	"string.join",
+	"strjoin",
+	"strlen",
+	"strlenutf8",
+	"strlower",
+	"strmatch",
+	"strrep",
+	"strrev",
+	"strsplit",
+	"strsub",
+	"strtrim",
+	"strupper",
+	"table.wipe",
+	"tan",
+	"time",
+	"tinsert",
+	"tremove",
+	"wipe",
+
+	-- framexml
+
+	-- everything else
+}
\ No newline at end of file

.pkgmeta

@@ -18,7 +18,7 @@ externals:
     Libs/LibCompress: svn://svn.wowace.com/wow/libcompress/mainline/trunk
     Libs/LibBase64-1.0: git://git.wowace.com/wow/libbase64-1-0/mainline.git
     Libs/LibDBIcon-1.0: svn://svn.wowace.com/wow/libdbicon-1-0/mainline/trunk/LibDBIcon-1.0
-    Libs/LibCustomGlow-1.0: https://repos.curseforge.com/wow/libcustomglow
+    Libs/LibCustomGlow-1.0: git://github.com/Stanzilla/LibCustomGlow.git
     Libs/LibClassicDurations: https://repos.curseforge.com/wow/libclassicdurations
     Libs/LibClassicHealComm-1.0: https://github.com/Aviana/LibClassicHealComm-1.0.git
 

.release/.env

+#!/bin/bash
+
+export CF_ID=7950
+export CF_API_KEY=
+export WOWI_ID=14239
+export WOWI_ID_TEST=
+export WOWI_API_TOKEN=
+export GITHUB_SLUG=
+export GITHUB_OAUTH=
+export GITLAB_SLUG=
+export GITLAB_API_TOKEN=

README.md

+Get [VuhDo release v3.107](https://www.curseforge.com/wow/addons/vuhdo) now with support for patch 8.2 Rise of Azshara!
+
+To get started read the updated [guide over at Icy-Veins](https://www.icy-veins.com/forums/topic/11805-vuhdo-a-comprehensive-guide/).
+
+Download user created VuhDo profiles, key layouts and custom bouquets over on [wago.io](https://wago.io)!
+
+Keep those feature requests and bug reports coming!
+Please [file VuhDo GitLab issues](https://gitlab.vuhdo.io/vuhdo/vuhdo/issues/new) to report any bugs or to make feature requests.
+
+Further reading:
+
+- [Frequently Asked Questions FAQ](http://vuhdoguide.blogspot.com/2011/08/frequently-asked-questions_18.html) (Thanks Zohar).
+- [Exhaustive VuhDo setup walkthrough](http://vuhdoguide.blogspot.com/2011/08/vuhdo-setup-walkthrough.html) (Thanks Zohar).
+
+What is VuhDo?
+
+VuhDo is a raid monitor similar to CTRaidAssist or Blizzards built-in raid frames. Basically this is about displaying the health of raid members in form of clearly arranged bars. VuhDo is primarily directed to healing classes, but will make use to almost any other class. Moreover several healing spells or other actions can be asserted to mouse clicks on those bars (Click-Heal).
+
+What VuhDo can do: 
+1. Display all relevant informations about your raid members
+- Life,
+- Mana, other types of power
+- Debuffs
+- Range
+- Incoming Heal
+- Aggro
+- Threat
+- HoTs
+- Charmed status
+- PvP status
+- Tooltips (for race, class, level and current location)
+- Player Tags (such as afk, disconnected, dead)
+- Shields
+
+2. Casting
+- You can heal, decurse, target, assist or focus raid memers with just one click
+- You can bind any usable item and any macro to mouse clicks
+- You can assign up to 40 mouse click combinations to cast on raid members
+- You can assign up to 16 keys to cast when mouse over
+- You can automatically fire your trinkets and instant casts whenever cooldown is over
+- You can automatically resurrect and decurse players out of combat
+
+3. Set up the raid
+- manage main tanks (CTRA/ORA compatible) and personally selected players.
+- Setup who is raid lead, assistant and master looter
+- Check who is one of the above
+
+4. Buffing
+- You can easily keep track of all of your buffs 
+- You can rebuff automatically chosing the most suitable spell and target
+- You can smart buff your raid automatically selecting missing buffs
+
+Special Features:
+- Up to 10 independent raid member panels
+- Completely free arrangement of raid members: You can move any group to any position in any panel: 
+You can select to see your groups by class, group number role or any combination.
+Easy group arrangement via Drag-n-Drop. 
+You can additionally setup to display Pets, Vehicles, Main Tanks, private Tanks.
+A panel setup wizard lets you setup most common settings with a few clicks
+- You can store different skins and arrangements of panels separately
+Supported standards / Compatibility:
+- CTRA/oRA: Main Tank setup / resurrection monitor
+- libSharedMedia: Fonts, Statusbar textures
+- Masque
+- Clique
+
+To be absolutely clear VuhDo is still fully supported and will continue to see bug fixes / new features.
+
+Below we have archived the parting message from Iza @ EU-Gilneas, the original creator of this amazing addon:
+> 2014-04-25: I (Iza) am sorry to announce that I'm not
+> going to further develop or maintain VuhDo anymore.
+> 
+> I haven't been actively playing wow for some years
+> now and lately - as you might have noticed - 
+> my efforts (and also interest) in maintaining and 
+> developing WoW addons tends to zero, so I'll be
+> gone for good I guess.
+> 
+> Thanks to a fine community for the great times 
+> and for sharing all the uncounted ideas and suggestions 
+> which finally have made VuhDo what I believe is a decent 
+> addon.
+> 
+> All the best to you & keep it going,
+> Iza
+
+
+If you enjoy using VuhDo please consider a small donation for Iza.
+(use the Donate button on the CurseForge project page)

VuhDo.toc

 ## Interface: 11302
 ## Title: VuhDo ['vu:du:]
 ## Author: Iza@Gilneas, humfras, Ivaria@Hyjal
-## Version: 3.102-classic
+## Version: 3.107-classic
 ## Notes: Raid Frames providing click-heal functionality, buff and debuff control, main tank management and much more
 ## SavedVariablesPerCharacter: VUHDO_CONFIG, VUHDO_PANEL_SETUP, VUHDO_SPELL_ASSIGNMENTS, VUHDO_HOSTILE_SPELL_ASSIGNMENTS, VUHDO_MM_SETTINGS, VUHDO_PLAYER_TARGETS, VUHDO_MAINTANK_NAMES, VUHDO_BUFF_SETTINGS, VUHDO_POWER_TYPE_COLORS, VUHDO_SPELLS_KEYBOARD, VUHDO_SPELL_CONFIG, VUHDO_BUFF_ORDER, VUHDO_SPEC_LAYOUTS, VUHDO_GROUP_SIZE, VUHDO_RAID, VUHDO_INDICATOR_CONFIG
 ## SavedVariables: VUHDO_DEFAULT_LAYOUT, VUHDO_DEFAULT_PROFILE, VUHDO_PROFILES, VUHDO_MANUAL_ROLES, VUHDO_SPELL_LAYOUTS, VUHDO_USER_CLASS_COLORS, VUHDO_DEBUFF_BLACKLIST, VUHDO_BOUQUETS, VUHDO_COMBAT_LOG_TRACE, VUHDO_GLOBAL_CONFIG, VUHDO_DEBUG

VuhDoAddonAdapter.lua

@@ -43,9 +43,9 @@ VUHDO_LibSharedMedia:Register("statusbar", "VuhDo - Plain White", "Interface\\Ad
 VUHDO_LibSharedMedia:Register("statusbar", "LiteStepLite", "Interface\\AddOns\\VuhDo\\Images\\LiteStepLite.tga");
 VUHDO_LibSharedMedia:Register("statusbar", "Tukui", "Interface\\AddOns\\VuhDo\\Images\\tukuibar.tga");
 
-VUHDO_LibSharedMedia:Register("sound", "Tribal Bass Drum", "Sound\\Doodad\\BellTollTribal.wav");
-VUHDO_LibSharedMedia:Register("sound", "Thorns", "Sound\\Spells\\Thorns.wav	");
-VUHDO_LibSharedMedia:Register("sound", "Elf Bell Toll", "Sound\\Doodad\\BellTollNightElf.wav");
+VUHDO_LibSharedMedia:Register("sound", "Tribal Bass Drum", 566027);
+VUHDO_LibSharedMedia:Register("sound", "Thorns", 569022);
+VUHDO_LibSharedMedia:Register("sound", "Elf Bell Toll", 566558);
 
 VUHDO_LibSharedMedia:Register("border", "Plain White", "Interface\\AddOns\\VuhDo\\Images\\white_square_16_16");
 

VuhDoBouquetValidators.lua

@@ -465,9 +465,9 @@ end
 local tPower;
 local function VUHDO_holyPowersEqualsValidator(anInfo, someCustom)
 	if anInfo["connected"] and not anInfo["dead"] then
-		tPower = UnitPower(anInfo["unit"], 9);
+		tPower = UnitPower(anInfo["unit"], VUHDO_UNIT_POWER_HOLY_POWER);
 		if tPower == someCustom["custom"][1] then
-			return true, nil, tPower, -1, UnitPowerMax(anInfo["unit"], 9);
+			return true, nil, tPower, -1, UnitPowerMax(anInfo["unit"], VUHDO_UNIT_POWER_HOLY_POWER);
 		else
 			return false, nil, -1, -1, -1;
 		end

VuhDoBuffWatchBuilder.lua

@@ -224,6 +224,14 @@ end
 
 --
 local sIsOutOfCombat = false;
+function VUHDO_getIsOutOfCombat()
+
+	return sIsOutOfCombat;
+
+end
+
+
+
 function VUHDO_setIsOutOfCombat(anIsEnded)
 	sIsOutOfCombat = anIsEnded;
 

VuhDoDebuffs.lua

@@ -187,13 +187,22 @@ end
 
 --
 local tNextSoundTime = 0;
-local function VUHDO_playDebuffSound(aSound)
+local function VUHDO_playDebuffSound(aSound, aDebuffName)
 	if (aSound or "") == "" or GetTime() < tNextSoundTime then
 		return;
 	end
 
-	PlaySoundFile(aSound);
-	tNextSoundTime = GetTime() + 2;
+	local tSuccess = VUHDO_playSoundFile(aSound);
+
+	if tSuccess then
+		tNextSoundTime = GetTime() + 2;
+	else
+		if aDebuffName then
+			VUHDO_Msg(format(VUHDO_I18N_PLAY_SOUND_FILE_CUSTOM_DEBUFF_ERR, aSound, aDebuffName));
+		else
+			VUHDO_Msg(format(VUHDO_I18N_PLAY_SOUND_FILE_DEBUFF_ERR, aSound));
+		end
+	end
 end
 
 
@@ -404,9 +413,9 @@ function VUHDO_determineDebuff(aUnit)
 					tDebuffSettings = sAllDebuffSettings[tName] or sAllDebuffSettings[tostring(tDebuffInfo[6])];
 
 					if tDebuffSettings then -- particular custom debuff sound?
-						VUHDO_playDebuffSound(tDebuffSettings["SOUND"]);
+						VUHDO_playDebuffSound(tDebuffSettings["SOUND"], tName);
 					elseif VUHDO_CONFIG["CUSTOM_DEBUFF"]["SOUND"] then -- default custom debuff sound?
-						VUHDO_playDebuffSound(VUHDO_CONFIG["CUSTOM_DEBUFF"]["SOUND"]);
+						VUHDO_playDebuffSound(VUHDO_CONFIG["CUSTOM_DEBUFF"]["SOUND"], tName);
 					end
 				end
 

VuhDoDefaults.lua

@@ -1910,6 +1910,53 @@ function VUHDO_loadDefaultConfig()
 		20475   -- Living Bomb
 	 );
 
+	--- 8.2.0 - Battle for Azeroth - Rise of Azshara
+	VUHDO_addCustomSpellIds(45,
+		-- [[ Eternal Palace ]]
+		-- Abyssal Commander
+--		294715, -- Toxic Brand
+--		294711, -- Frost Mark
+		295421, -- Overflowing Venom
+		295348, -- Overflowing Chill
+		300882, -- Inversion Sickness
+		300957, -- Inversion Sickness
+		-- Blackwater Behemoth
+		292127, -- Darkest Depths
+--		292133, -- Bioluminescence
+		292307, -- Gaze from Below
+		292167, -- Toxic Spine
+		301494, -- Piercing Barb
+		298595, -- Glowing Stinger
+		-- Radiance of Aszhara
+		296737, -- Arcane Bomb
+		296746, -- Arcane Bomb
+		-- Lady Ashvane
+		296693, -- Waterlogged
+		297333, -- Briny Bubble
+		-- Orgozoa
+		298306, -- Incubation Fluid
+		295779, -- Aqua Lance
+		-- The Queen's Court
+		297586, -- Suffering
+		299914, -- Frenetic Charge
+		296851, -- Fanatical Verdict
+		300545, -- Mighty Rupture
+		-- Za'qul
+		292971, -- Hysteria
+		292963, -- Dread
+		293509, -- Manifest Nightmares
+		298192, -- Dark Beyond
+		-- Queen Azshara
+--		298569, -- Drained Soul
+--		301078, -- Charged Spear 
+--		299094, -- Beckon
+		303828, -- Crushing Depths
+		303825, -- Crushing Depths
+		303657, -- Arcane Burst
+		300492, -- Static Shock
+		297907  -- Cursed Heart
+	);
+
 	local debuffRemovalList = {};
 
 	for tIndex, tName in pairs(VUHDO_CONFIG["CUSTOM_DEBUFF"]["STORED"]) do

VuhDoEventHandler.lua

@@ -696,9 +696,11 @@ function VUHDO_OnEvent(_, anEvent, anArg1, anArg2, anArg3, anArg4, anArg5, anArg
 		if VUHDO_VARIABLES_LOADED and not InCombatLockdown() then
 			if "player" == anArg1 then
 				local tSpecNum = tostring(VUHDO_getSpecialization()) or "1";
+				local tBestProfile = VUHDO_getBestProfileAfterSpecChange();
 
 				-- event sometimes fires multiple times so we must de-dupe
-				if VUHDO_SPEC_LAYOUTS["selected"] ~= VUHDO_SPEC_LAYOUTS[tSpecNum] then
+				if (VUHDO_SPEC_LAYOUTS["selected"] ~= VUHDO_SPEC_LAYOUTS[tSpecNum]) or 
+					(VUHDO_CONFIG["CURRENT_PROFILE"] ~= tBestProfile) then
 					VUHDO_activateSpecc(tSpecNum);
 				end
 			end

VuhDoLocalization_de.lua

@@ -472,3 +472,8 @@ VUHDO_I18N_DEF_PLAYER_ARCANE_CHARGES = "Player Arcane Charges";
 VUHDO_I18N_BOUQUET_OWN_ARCANE_CHARGES_EQUALS = "Flag: Own Arcane Charges ==";
 VUHDO_I18N_DEBUFF_BLACKLIST_ADDED = "Added \"[%s] %s\" to the debuff backlist.";
 
+-- 3.104
+VUHDO_I18N_PLAY_SOUND_FILE_ERR = "Could not play sound \"%s\": %s";
+VUHDO_I18N_PLAY_SOUND_FILE_DEBUFF_ERR = "Could not play sound \"%s\" for standard debuff. Adjust your settings under 'VuhDo Options > Debuffs > Standard > Debuff Sound'.";
+VUHDO_I18N_PLAY_SOUND_FILE_CUSTOM_DEBUFF_ERR = "Could not play sound \"%s\" for custom debuff \"%s\". Adjust your settings under 'VuhDo Options > Debuffs > Custom'.";
+

VuhDoLocalization_en.lua

@@ -481,3 +481,8 @@ VUHDO_I18N_DEF_PLAYER_ARCANE_CHARGES = "Player Arcane Charges";
 VUHDO_I18N_BOUQUET_OWN_ARCANE_CHARGES_EQUALS = "Flag: Own Arcane Charges ==";
 VUHDO_I18N_DEBUFF_BLACKLIST_ADDED = "Added \"[%s] %s\" to the debuff backlist.";
 
+-- 3.104
+VUHDO_I18N_PLAY_SOUND_FILE_ERR = "Could not play sound \"%s\": %s";
+VUHDO_I18N_PLAY_SOUND_FILE_DEBUFF_ERR = "Could not play sound \"%s\" for standard debuff. Adjust your settings under 'VuhDo Options > Debuffs > Standard > Debuff Sound'.";
+VUHDO_I18N_PLAY_SOUND_FILE_CUSTOM_DEBUFF_ERR = "Could not play sound \"%s\" for custom debuff \"%s\". Adjust your settings under 'VuhDo Options > Debuffs > Custom'.";
+

VuhDoLocalization_es.lua

@@ -482,3 +482,8 @@ VUHDO_I18N_DEF_PLAYER_ARCANE_CHARGES = "Player Arcane Charges";
 VUHDO_I18N_BOUQUET_OWN_ARCANE_CHARGES_EQUALS = "Flag: Own Arcane Charges ==";
 VUHDO_I18N_DEBUFF_BLACKLIST_ADDED = "Added \"[%s] %s\" to the debuff backlist.";
 
+-- 3.104
+VUHDO_I18N_PLAY_SOUND_FILE_ERR = "Could not play sound \"%s\": %s";
+VUHDO_I18N_PLAY_SOUND_FILE_DEBUFF_ERR = "Could not play sound \"%s\" for standard debuff. Adjust your settings under 'VuhDo Options > Debuffs > Standard > Debuff Sound'.";
+VUHDO_I18N_PLAY_SOUND_FILE_CUSTOM_DEBUFF_ERR = "Could not play sound \"%s\" for custom debuff \"%s\". Adjust your settings under 'VuhDo Options > Debuffs > Custom'.";
+

VuhDoLocalization_fr.lua

@@ -480,3 +480,8 @@ VUHDO_I18N_DEF_PLAYER_ARCANE_CHARGES = "Player Arcane Charges";
 VUHDO_I18N_BOUQUET_OWN_ARCANE_CHARGES_EQUALS = "Flag: Own Arcane Charges ==";
 VUHDO_I18N_DEBUFF_BLACKLIST_ADDED = "Added \"[%s] %s\" to the debuff backlist.";
 
+-- 3.104
+VUHDO_I18N_PLAY_SOUND_FILE_ERR = "Could not play sound \"%s\": %s";
+VUHDO_I18N_PLAY_SOUND_FILE_DEBUFF_ERR = "Could not play sound \"%s\" for standard debuff. Adjust your settings under 'VuhDo Options > Debuffs > Standard > Debuff Sound'.";
+VUHDO_I18N_PLAY_SOUND_FILE_CUSTOM_DEBUFF_ERR = "Could not play sound \"%s\" for custom debuff \"%s\". Adjust your settings under 'VuhDo Options > Debuffs > Custom'.";
+