Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
VuhDo VuhDo
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 278
    • Issues 278
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • VuhDo
  • VuhDoVuhDo
  • Issues
  • #714

Closed
Open
Created Feb 25, 2023 by Sixthly@Sixthly

Third-party frames break Type and Value dropdown menus in VuhDo panel configuration

Confirm the issue lies within VuhDo:

While this issue does rely on a third-party frame, it is worth noting that the issue is within VuhDo's code and is triggered when VuhDo is integrated with other addons such as WeakAuras.

Describe your environment:

  • VuhDo version 3.147, retail.
  • Americas/Oceanic
  • enUS

Summary of the issue:

When configuring a panel in the Move tab of VuhDo, third-party frames children to VuhDo's healing buttons can cause the Type and Value dropdown menus to break. This is a common issue when using WeakAuras to create a glow effect on a VuhDo healing button. The problem is located within VuhDo's code, and it can be resolved by making the following change to VuhDoLookAndFeel.lua:376:

if tComponent.GetName and strfind(tComponent:GetName() or "", "Combo") then

Expected behaviour:

The Type and Value dropdown menus should work as expected even when third-party frames are anchored to VuhDo's healing buttons.

Actual behaviour:

The Type and Value dropdown menus dropdown menus do not work as expected when third-party frames are anchored to VuhDo's healing buttons.

Related error messages:

13x VuhDoOptions/VuhDoLookAndFeel.lua:376: bad argument #1 to 'strfind' (string expected, got nil)
[string "=[C]"]: ?
[string "@VuhDoOptions/VuhDoLookAndFeel.lua"]:376: in function <VuhDoOptions/VuhDoLookAndFeel.lua:366>
[string "@VuhDoOptions/VuhDoLookAndFeel.lua"]:399: in function `VUHDO_lnfComboButtonClicked'
[string "*VuhDoLookAndFeel.xml:1510_OnClick"]:1: in function <[string "*VuhDoLookAndFeel.xml:1510_OnClick"]:1>

Locals:
(*temporary) = nil
(*temporary) = "Combo"
(*temporary) = "string expected, got nil"
Edited Feb 25, 2023 by Sixthly
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking