Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
VuhDo VuhDo
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 277
    • Issues 277
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • VuhDo
  • VuhDoVuhDo
  • Issues
  • #601

Closed
Open
Created Nov 19, 2022 by Michael Shiery@shieryma

RoleChecker for Prot Paladin - Proposed Fix

Issue: Prot paladin does not show up as Melee-Tank when there is no tank role override.

Code Section in "VuhDoRoleChecker" with Issue:
elseif 23 == tClassId then -- VUHDO_ID_PALADINS
if 0 > 2 then -- FIXME: need replacement for UnitDefense check
return 60; -- VUHDO_ID_MELEE_TANK

Proposed Fix:
elseif 23 == tClassId then -- VUHDO_ID_PALADINS
if GetSpecialization()==2 then -- FIXME: need replacement for UnitDefense check
return 60; -- VUHDO_ID_MELEE_TANK

Will work as long as Blizzard does not reorder specializations. Tested and works, but I'm a noob so there could be an issue I'm not aware of.

Edited Nov 19, 2022 by Michael Shiery
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking