Local Keyboard assignment not updating when learning a spell
Minor issue
When learning a spell which I already have assigned to a local key (such as by selecting a talent which grants the spell), the keybind does not function until opening Vuhdo's options, or reloading the UI (unless I have previously had it learned and bound correctly within the same session).
When looking at Vuhdo's event handler for the "LEARNED_SPELL_IN_TAB" event, I noticed the comment:
"FIXME: this event does not fire when spell is learned via talent change"
I'm unsure if the recent talents overhaul changed this, but the event does seem to fire upon learning a spell via a talent swap now at least. I've personally just done a quick and dirty edit to that event handler, to have it re-activate my current spec's key layout, but I imagine you would have a cleaner implementation.
The newly learned spells still seem to function when bound to mouse buttons, though the spells don't seem to actually use Vuhdo's macro template until opening the options or reloading the UI, etc.
As an aside, I was going to check if this also applied to global keybindings too, but I seem unable to find the global keybindings for Vuhdo in the new keybindings section. Searching for Vuhdo only brings up a single bindable key named "HEADER_VUHDO_TITLE". I don't personally use them, but I thought I'd report another possible issue.
Huge fan of the addon for many years now, really appreciate all the work on it! Hope some of this info is helpful.
P.S. If I were to suggest one small feature: I believe Smart casting a Resurrection spell will always prioritize the class's Mass Ress spell, if learned? There are actaully some situations (mostly in M+) in which a single target ress would be preferable, because I believe other party members entering combat can interrupt your Mass Ress (at least, that used to be the case, afaik).
Would it be possible to add an option to allow a player to choose between always smart casting a single target Ress vs always smart casting a Mass Ress? I could see myself wanting to single target ress individual players who die, between packs, whilst just having Mass Ress on its own global hotkey, outside of vuhdo.