Workaround for GetSpellBookItemInfo bug for new resto Shaman Water Shield -...

Workaround for GetSpellBookItemInfo bug for new resto Shaman Water Shield - closes CurseForge ticket 339

VuhDoBuffConst.lua

@@ -255,7 +255,7 @@ VUHDO_CLASS_BUFFS = {
 			{ VUHDO_SPELL_ID.BUFF_ASPECT_OF_THE_PACK, VUHDO_BUFF_TARGET_SELF },
 			{ VUHDO_SPELL_ID.BUFF_ASPECT_OF_THE_FOX, VUHDO_BUFF_TARGET_SELF },
 			{ VUHDO_SPELL_ID.BUFF_ASPECT_OF_THE_CEETAH, VUHDO_BUFF_TARGET_SELF },
-			--{ VUHDO_SPELL_ID.BUFF_IRON_HAWK, VUHDO_BUFF_TARGET_SELF },
+			{ VUHDO_SPELL_ID.BUFF_IRON_HAWK, VUHDO_BUFF_TARGET_SELF },
 		},
 	},
 

VuhDoBuffWatch.lua

@@ -364,15 +364,20 @@ function VUHDO_initBuffsFromSpellBook()
 
 	local tSpellName, tSpellId, tIcon;
 
+	-- GetSpellBookItemInfo is bugged for Hunter Iron Hawk
 	if "HUNTER" == VUHDO_PLAYER_CLASS then
 		VUHDO_BUFFS[VUHDO_SPELL_ID.BUFF_IRON_HAWK] = {
 			["icon"] = select(3, GetSpellInfo(109260)),
 			["id"] = 109260,
 		};
+	end
 
-		tinsert(VUHDO_getPlayerClassBuffs()[VUHDO_I18N_BUFFC_ASPECT],
-			{ VUHDO_SPELL_ID.BUFF_IRON_HAWK, VUHDO_BUFF_TARGET_SELF }
-		);
+	-- GetSpellBookItemInfo is bugged for Shaman Water Shield
+	if "SHAMAN" == VUHDO_PLAYER_CLASS then
+		VUHDO_BUFFS[VUHDO_SPELL_ID.BUFF_WATER_SHIELD] = {
+			["icon"] = select(3, GetSpellInfo(52127)),
+			["id"] = 52127,
+		};
 	end
 
 	for _, tCateg in pairs(VUHDO_getPlayerClassBuffs()) do

VuhDoOptions/VuhDoLocalization_en.lua

@@ -531,8 +531,8 @@ VUHDO_I18N_TT.K471 = "Makes bars grow from right to left.";
 VUHDO_I18N_TT.K472 = "Indicates units taking severe damage by flashing the health bars.";
 VUHDO_I18N_TT.K473 = "Enable this to show HoT squares using the original icon.";
 VUHDO_I18N_TT.K474 = "Enable this to show HoT squares using a glossy texture.";
-VUHDO_I18N_TT.K475 = "Auto-Enable profile whenever switching to primary specc";
-VUHDO_I18N_TT.K476 = "Auto-Enable profile whenever switching to secondaray specc";
+VUHDO_I18N_TT.K475 = "Auto-Enable profile whenever switching to primary spec.";
+VUHDO_I18N_TT.K476 = "Auto-Enable profile whenever switching to secondaray spec.";
 VUHDO_I18N_TT.K477 = "In this Menu you can reset several aspects of your configuration to factory defaults";
 VUHDO_I18N_TT.K478 = "Click to return to where you came from.";
 VUHDO_I18N_TT.K479 = "Only if the spell in this edit box has no cooldown clusters will be shown. Clear for to show clusters always.";

VuhDoOptions/VuhDoLocalization_es.lua

@@ -539,8 +539,8 @@ VUHDO_I18N_TT.K471 = "Makes bars grow from right to left.";
 VUHDO_I18N_TT.K472 = "Indicates units taking severe damage by flashing the health bars.";
 VUHDO_I18N_TT.K473 = "Enable this to show HoT squares using the original icon.";
 VUHDO_I18N_TT.K474 = "Enable this to show HoT squares using a glossy texture.";
-VUHDO_I18N_TT.K475 = "Auto-Enable profile whenever switching to primary specc";
-VUHDO_I18N_TT.K476 = "Auto-Enable profile whenever switching to secondaray specc";
+VUHDO_I18N_TT.K475 = "Auto-Enable profile whenever switching to primary spec.";
+VUHDO_I18N_TT.K476 = "Auto-Enable profile whenever switching to secondaray spec.";
 VUHDO_I18N_TT.K477 = "In this Menu you can reset several aspects of your configuration to factory defaults";
 VUHDO_I18N_TT.K478 = "Click to return to where you came from.";
 VUHDO_I18N_TT.K479 = "Only if the spell in this edit box has no cooldown clusters will be shown. Clear for to show always.";

VuhDoOptions/VuhDoLocalization_fr.lua

@@ -541,8 +541,8 @@ VUHDO_I18N_TT.K471 = "Makes bars grow from right to left.";
 VUHDO_I18N_TT.K472 = "Indicates units taking severe damage by flashing the health bars.";
 VUHDO_I18N_TT.K473 = "Enable this to show HoT squares using the original icon.";
 VUHDO_I18N_TT.K474 = "Enable this to show HoT squares using a glossy texture.";
-VUHDO_I18N_TT.K475 = "Auto-Enable profile whenever switching to primary specc";
-VUHDO_I18N_TT.K476 = "Auto-Enable profile whenever switching to secondaray specc";
+VUHDO_I18N_TT.K475 = "Auto-Enable profile whenever switching to primary spec.";
+VUHDO_I18N_TT.K476 = "Auto-Enable profile whenever switching to secondaray spec.";
 VUHDO_I18N_TT.K477 = "In this Menu you can reset several aspects of your configuration to factory defaults";
 VUHDO_I18N_TT.K478 = "Click to return to where you came from.";
 VUHDO_I18N_TT.K479 = "Only if the spell in this edit box has no cooldown clusters will be shown. Clear for to show always.";

VuhDoToolbox.lua

@@ -453,13 +453,14 @@ end
 
 
 --
-function VUHDO_isTalentKnown(aTalentName, onlyActiveSpec)
+function VUHDO_getTalentSpellId(aTalentName, onlyActiveSpec)
 	if onlyActiveSpec then
 		for tier=1,7 do
 			for column=1,3 do
-				local id, name, texture, selected, available = GetTalentInfo(tier,column,GetActiveSpecGroup())
+				local id, name, _, selected, _ = GetTalentInfo(tier, column, GetActiveSpecGroup());
+
 				if name == aTalentName and selected then
-					return true
+					return id;
 				end
 			end
 		end
@@ -467,15 +468,22 @@ function VUHDO_isTalentKnown(aTalentName, onlyActiveSpec)
 		for group=1,2 do
 			for tier=1,7 do
 				for column=1,3 do
-					local id, name, texture, selected, available = GetTalentInfo(tier,column,group)
+					local id, name, _, selected, _ = GetTalentInfo(tier, column, group);
 					if name == aTalentName and selected then
-						return true
+						return id;
 					end
 				end
 			end
 		end
 	end
-	return false
+
+	return nil;
+end
+
+
+--
+function VUHDO_isTalentKnown(aTalentName, onlyActiveSpec)
+	return VUHDO_getTalentSpellId(aTalentName, onlyActiveSpec) and true or false;
 end
 
 

changelog.txt

@@ -68,7 +68,7 @@ TODO:
 --   Appears to not be a bug in VuhDo
 --   UnitGetIncomingHeals API seems to return bogus values on beta/PTR?
 -- Updated AOE advisor spell bases
---   Healing spell base values have been removed (eg. H = Cx + B is now H = Cx)
+--   Healing spell base values have been removed (H = Cx + B is now H = Cx)
 --   Need to empirically test coefficients shown on beta tooltips
 --   Use Hamlet's updated spreadsheet for WoD?
 -- Updated AOE advisor glyph item IDs