GitLab

VuhDo version v3.196 mopc Wow EU client enUS

Summary of the issue:

In Raid group, group 1 does not show any members if main tank is selected on filters (General tab) and some players in grp 1 have tank role

This maybe related to #1145 (closed)

Expected behaviour:

When in a raid group when main tank is selected on filters (General tab) and both main tanks and non-main tanks are present in group 1, main tanks are excluded (but non-main tanks are not)

Actual behaviour:

In Raid group when main tank is selected on filters (General tab) and both main tanks and non-main tanks are present in group 1, all players are excluded in group 1

to reproduce issue, be in raid with main tank filter selected and have some players in grp 1 that have tank role and some that are non-main tanks.

no error messages are displayed.

This defect seems to be related to commit 414bb40e

replacing the code change in vuhdo.lua at line 551:

		VUHDO_tableRemoveValue(tAllUnits, aUnit);

with the original

		for tIndex, tUnit in pairs(tAllUnits) do
			if tUnit == aUnit then tremove(tAllUnits, tIndex); end

resolves the issue (tested ingame)