From 1ac588a3fcb4bd32d0a84126a67a201ffc38f2a3 Mon Sep 17 00:00:00 2001
From: Ivaria <ivaria@vuhdo.io>
Date: Sat, 29 Oct 2016 04:55:08 +0000
Subject: [PATCH] Fixed font dropshadow offset which Blizzard broke in 7.1.
Shadow offset is not scaling properly with resolution. Hardcoded the offset
to be optimal for 1920x1080 for now.
---
VuhDoGuiToolbox.lua | 6 +++++-
VuhDoOptions/VuhDoLookAndFeelStandardFont.lua | 5 ++++-
changelog.txt | 3 +++
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/VuhDoGuiToolbox.lua b/VuhDoGuiToolbox.lua
index bff5146..56404d9 100644
--- a/VuhDoGuiToolbox.lua
+++ b/VuhDoGuiToolbox.lua
@@ -746,7 +746,11 @@ function VUHDO_customizeIconText(aParent, aHeight, aLabel, aSetup)
end
aLabel:SetFont(aSetup["FONT"], tFactor * aSetup["SCALE"], tOutline);
- aLabel:SetShadowOffset(1, -1);
+
+ -- patch 7.1 introduced a bug with shadow offset scaling by resolution
+ -- hardcode the offset to -3 for now which should be the equiv of -1 @ 1920x1080
+ aLabel:SetShadowOffset(1, -3);
+
aLabel:SetText("");
end
diff --git a/VuhDoOptions/VuhDoLookAndFeelStandardFont.lua b/VuhDoOptions/VuhDoLookAndFeelStandardFont.lua
index 8831da8..ccce5ce 100644
--- a/VuhDoOptions/VuhDoLookAndFeelStandardFont.lua
+++ b/VuhDoOptions/VuhDoLookAndFeelStandardFont.lua
@@ -122,7 +122,10 @@ function VUHDO_lnfStandardFontUpdateDemoText()
else
tLabel:SetShadowColor(0, 0, 0, tShadowAlpha);
end
- tLabel:SetShadowOffset(1, -1);
+
+ -- patch 7.1 introduced a bug with shadow offset scaling by resolution
+ -- hardcode the offset to -3 for now which should be the equiv of -1 @ 1920x1080
+ tLabel:SetShadowOffset(1, -3);
if (sTable["COLOR"] ~= nil) then
tLabel:SetTextColor(VUHDO_textColor(sTable["COLOR"]));
diff --git a/changelog.txt b/changelog.txt
index fc055cc..9a59070 100644
--- a/changelog.txt
+++ b/changelog.txt
@@ -16,6 +16,9 @@ Known issues:
Bugfixes:
-- Fixed handling of empty values in health related combat log events
-- Disabled retrieval of unit facing and map position inside instances
+-- Fixed font dropshadow offset which Blizzard broke in 7.1
+-- Shadow offset is not scaling properly with resolution
+-- Hardcoded the offset to be optimal for 1920x1080 for now
--------------------------------------------------------------
--
GitLab